add modifiers to render tree #2548
Conversation
patricklx
force-pushed
the
add-modifiers
branch
3 times, most recently
from
2fdb1b3 to
100e6c5
Compare
|
|
patricklx
force-pushed
the
add-modifiers
branch
4 times, most recently
from
f3a27ba to
4fad590
Compare
patricklx
force-pushed
the
add-modifiers
branch
13 times, most recently
from
7c5e545 to
7a5e83e
Compare
| @@ -5,6 +5,7 @@ | |||
| <title>EmberInspector Tests</title> | |||
| <meta name="description" content=""> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <base href="../" /> | |||
There was a problem hiding this comment.
then i can build --watch and also just open dist/testing/tests/index.html
|
this is ready. I tried to support all versions we currently check and also make it robust in case some things are not available. |
|
@patricklx the code and tests look great here, thank you for taking this on! I was looking at the screenshot though, and shouldn't the modifier be inside the element? They seem to be outside of the closing |
|
pushed the changes |
patricklx
force-pushed
the
add-modifiers
branch
from
5ac4ce8 to
9c6c8cd
Compare
patricklx
force-pushed
the
add-modifiers
branch
from
9c6c8cd to
a798086
Compare
|
@RobbieTheWagner what about this? |
patricklx
force-pushed
the
add-modifiers
branch
from
75284a7 to
724e4b8
Compare
|
I found that this might need more work. The modifiers need to be removed from debug render tree when they get destroyed |
patricklx
force-pushed
the
add-modifiers
branch
9 times, most recently
from
2d1f748 to
6177e06
Compare
|
@RobbieTheWagner ready |
|
@patricklx looks like there are some conflicts. Would you mind resolving those please? |
patricklx
force-pushed
the
add-modifiers
branch
from
6177e06 to
02a184c
Compare
|
@RobbieTheWagner rebased |
Description
this adds modifiers and their html element to the render tree.
this also improves the UX for positional args, especially functions
this builds on #2549
Screenshots